Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using TypeScript #1159

Merged
merged 22 commits into from
Dec 21, 2023
Merged

Switch to using TypeScript #1159

merged 22 commits into from
Dec 21, 2023

Conversation

gjmooney
Copy link
Contributor

Start converting ipyleaflet to typescript

martinRenou
martinRenou requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

Just requesting to remove commented out code

js/src/amd-public-path.ts Outdated Show resolved Hide resolved
js/src/embed.ts Outdated Show resolved Hide resolved
js/src/extension.ts Outdated Show resolved Hide resolved
js/src/index.ts Outdated Show resolved Hide resolved
js/src/jupyterlab-plugin.ts Outdated Show resolved Hide resolved
js/tsconfig.json Outdated Show resolved Hide resolved
martinRenou
martinRenou approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou marked this pull request as ready for review December 21, 2023 11:40
@martinRenou martinRenou merged commit f8bf179 into jupyter-widgets:master Dec 21, 2023
3 of 4 checks passed
@martinRenou martinRenou changed the title Add typescript Switch to using TypeScript Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjmooney @martinRenou